Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FakeHLT steps to Patatrack WFs. #32350

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Add FakeHLT steps to Patatrack WFs. #32350

merged 1 commit into from
Dec 2, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 1, 2020

PR description:

The 2018 GPU matrix WFs (10824.502, 10824.512, 10824.522, 10842.502) produced the same cmsDriver configurations as their CPU counterparts. This PR fixes this by setting the gpu modifier also for the RecoFakeHLT step.

PR validation:

Running runTheMatrix.py --showMatrix --extended -l 10824.502,10824.512,10824.522,10842.502 | grep -i gpu confirms that all four WFs now have a step3 containing --procModifiers gpu.

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32333 to CMSSW 11.2.x .

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 1, 2020

backport #32333

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 1, 2020

please test

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Dec 1, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020 •
edited
Loading

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_2_X.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 254ed45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308c52/11205/summary.html
CMSSW: CMSSW_11_2_X_2020-11-30-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308c52/11205/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529558
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 34 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 1, 2020

+upgrade

@chayanit
Copy link

chayanit commented Dec 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 2, 2020

+1

@cmsbuild cmsbuild merged commit f6b9ccb into cms-sw:CMSSW_11_2_X Dec 2, 2020
@fwyzard fwyzard deleted the backport_32333 branch December 27, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
6 participants
@fwyzard @cmsbuild @kpedro88 @chayanit @qliphy @thomreis